Fixing Pre-2002 data bug in fg_batter_leaders function #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed variable renaming line that was breaking the function
Removed renaming line that was breaking the function when used for years < 2002 due to fangraphs' addition of pitch f/x data
williamohandley
changed the title
saiemgilani
approved these changes
Jan 9, 2024
saiemgilani
merged commit e855983
into
BillPetti:development_branch
0 of 4 checks passed
saiemgilani
added a commit
that referenced
this pull request
Jan 9, 2024
* Fixing Pre-2002 data bug in fg_batter_leaders function (#320) * Update fg_pitcher_leaders.R Removed variable renaming line that was breaking the function * Update fg_batter_leaders.R Removed renaming line that was breaking the function when used for years < 2002 due to fangraphs' addition of pitch f/x data * update tests --------- Co-authored-by: williamohandley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed lines breaking code in both fg_pitcher_leaders and fg_batter_leaders, as pre-2002 seasons don't have the FB_pct1 column, breaking the dplyr chain